Skip to content

chore: updated packages, fixed build bugs and migrated packages#6803

Merged
bmuenzenmeyer merged 9 commits intomainfrom
chore/updated-packages-and-fixed-build
Jun 5, 2024
Merged

chore: updated packages, fixed build bugs and migrated packages#6803
bmuenzenmeyer merged 9 commits intomainfrom
chore/updated-packages-and-fixed-build

Conversation

@ovflowd
Copy link
Copy Markdown
Member

@ovflowd ovflowd commented Jun 3, 2024

Description

  • Updates all packages to their latest minor versions as safe as possible
  • Upgraded to Sentry 8x (and migrated) package for Next.js, introducing usage of Next.js's Telemetry module and OpenTelemtry
  • Updated Shiki usage to import the main package directly whenever possible and force Next.js to do optimized module resolution for the 'shiki' package
  • Disabled --turbo for the time being, which reduces local development speed, but otherwise we can't update to Next.js 14.2

Validation

Local development, build and deployments should work as expected

@ovflowd ovflowd requested review from a team as code owners June 3, 2024 12:36
@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 5, 2024 8:40am

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Jun 3, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 91 🟢 100 🟢 96 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 96 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 99 🟢 100 🟢 96 🟢 92 🔗

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.67% (593/654) 76.08% (175/230) 94.57% (122/129)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.169s ⏱️

Copy link
Copy Markdown
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will an open an issue to track progress on re-enabling the turbo flag (I saw you reached out to folks at Vercel).

@ovflowd ovflowd force-pushed the chore/updated-packages-and-fixed-build branch from e41400f to 75a6112 Compare June 5, 2024 08:34
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Jun 5, 2024
@github-actions github-actions Bot removed the github_actions:pull-request Trigger Pull Request Checks label Jun 5, 2024
@ovflowd
Copy link
Copy Markdown
Member Author

ovflowd commented Jun 5, 2024

@MattIPv4 could you give a review? We need Web Infra to review this PR 🙇

@ovflowd

This comment was marked as resolved.

Copy link
Copy Markdown
Contributor

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works locally

Comment thread next.config.mjs
@bmuenzenmeyer

This comment was marked as resolved.

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Jun 5, 2024
Merged via the queue into main with commit 20d773e Jun 5, 2024
@bmuenzenmeyer bmuenzenmeyer deleted the chore/updated-packages-and-fixed-build branch June 5, 2024 12:47
@MattIPv4
Copy link
Copy Markdown
Member

MattIPv4 commented Jun 5, 2024

@MattIPv4 could you give a review? We need Web Infra to review this PR 🙇

Sorry for the slow response, am hiking around New Zealand currently. Looks like this was merged okay?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants